Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review129452 --- src/examples/test_http_executor.cpp (lines 192 - 194)

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

> On March 25, 2016, 9:23 p.m., Vinod Kone wrote: > > Ship It! > > Vinod Kone wrote: > Can you rebase? Just rebased the review request. Thanks a lot! - Yong --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- (Updated March 25, 2016, 9:25 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

> On March 25, 2016, 9:23 p.m., Vinod Kone wrote: > > Ship It! Can you rebase? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125476

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125476 --- Ship it! Ship It! - Vinod Kone On March 25, 2016, 9:19 p.m.,

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

> On March 25, 2016, 8:22 p.m., Vinod Kone wrote: > > LGTM modulo Anand's comments. Please also update the CHANGELOG. Hi Vinod, the CHANGELOG has been updated. Let me know if there are other issues and thanks a lot for the review. - Yong -

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

> On March 25, 2016, 8:18 p.m., Anand Mazumdar wrote: > > Can you also make a similar change as https://reviews.apache.org/r/45317/ > > to `src/slave/validation.cpp` if `Call::Type` is not present. Hi Anand, the review request has been updated. Let me know if there are other issues. Again, th

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- (Updated March 25, 2016, 9:19 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125465 --- LGTM modulo Anand's comments. Please also update the CHANGELOG. -

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125463 --- Can you also make a similar change as https://reviews.apache.org/

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- (Updated March 25, 2016, 6:58 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125377 --- Patch looks great! Reviews applied: [45304] Passed command: expo

Review Request 45304: Change Call and Event Type enums in executor.proto optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5015 https://issues.ap