Re: Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45808/#review127545 --- Ship it! Ship It! - Vinod Kone On April 7, 2016, 2:25 a.m.,

Re: Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45808/ --- (Updated 四月 7, 2016, 2:25 a.m.) Review request for mesos, Ben Mahler and Vinod

Re: Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

> On 四月 6, 2016, 6:15 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 2089-2092 > > > > > > we always use braces around our if and else blocks. > > > > if () { > > > > } else { > > >

Re: Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45808/#review127391 --- src/master/master.cpp (lines 2085 - 2088)

Re: Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45808/#review127349 --- Patch looks great! Reviews applied: [45808] Passed command: expo

Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45808/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-4981 https