Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Ch

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/#review128078 --- src/uri/fetchers/docker.cpp (lines 323 - 325)

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On 四月 11, 2016, 7:37 a.m., Guangya Liu wrote: > > src/uri/fetchers/docker.cpp, line 636 > > > > > > Add a log here to identify that the fetcher is now using auth to fetch > > the image? Adding the log in `getCred

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/#review128116 --- Patch looks great! Reviews applied: [45949, 45950, 45951, 45952]

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/ --- (Updated May 23, 2016, 2:52 p.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On April 11, 2016, 12:37 a.m., Guangya Liu wrote: > > src/uri/fetchers/docker.cpp, lines 323-325 > > > > > > Does there are any document change for this? Unfortunately, we dont have document for docker fetcher yet

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On 四月 11, 2016, 7:37 a.m., Guangya Liu wrote: > > src/uri/fetchers/docker.cpp, line 636 > > > > > > Add a log here to identify that the fetcher is now using auth to fetch > > the image? > > Guangya Liu wrote: >

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/ --- (Updated May 24, 2016, 6:33 p.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/#review136387 --- src/uri/fetchers/docker.cpp (line 281)

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/ --- (Updated June 10, 2016, 5:42 p.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/#review137183 --- Fix it, then Ship it! src/uri/fetchers/docker.cpp (lines 645 -

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On June 12, 2016, 11:08 a.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, lines 647-649 > > > > > > I don't get this part. This is not what you're doing here, right? I > > think a request to authorization serve

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On June 12, 2016, 11:08 a.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, lines 647-649 > > > > > > I don't get this part. This is not what you're doing here, right? I > > think a request to authorization serve

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On June 12, 2016, 6:08 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, lines 647-649 > > > > > > I don't get this part. This is not what you're doing here, right? I > > think a request to authorization server

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/ --- (Updated June 12, 2016, 12:11 p.m.) Review request for mesos, Guangya Liu, Arte

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On June 12, 2016, 11:08 a.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, lines 647-649 > > > > > > I don't get this part. This is not what you're doing here, right? I > > think a request to authorization serve

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On June 12, 2016, 6:08 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, lines 647-649 > > > > > > I don't get this part. This is not what you're doing here, right? I > > think a request to authorization server