Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review130172 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 5:28

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-21 Thread Yong Tang
> On April 21, 2016, 8:49 p.m., Vinod Kone wrote: > > Thanks for the detailed review. The path has been updated. Please let me know if there are any other issues. - Yong --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review129948 --- src/examples/test_http_framework.cpp (line 187)

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-20 Thread Yong Tang
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote: > > can you also update cli/execute.cpp, examples/test_http_framework.cpp, > > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, > > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp? > > > >

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-20 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/ --- (Updated April 21, 2016, 2:28 a.m.) Review request for mesos, Adam B, Ben

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-20 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/ --- (Updated April 21, 2016, 2:25 a.m.) Review request for mesos, Adam B, Ben

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-19 Thread Vinod Kone
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote: > > can you also update cli/execute.cpp, examples/test_http_framework.cpp, > > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, > > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp? > > > >

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-19 Thread Yong Tang
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote: > > can you also update cli/execute.cpp, examples/test_http_framework.cpp, > > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, > > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp? > > > >

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review129599 --- Patch looks great! Reviews applied: [46364] Passed command:

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-19 Thread Yong Tang
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote: > > can you also update cli/execute.cpp, examples/test_http_framework.cpp, > > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, > > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp? > > > >

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-19 Thread Yong Tang
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote: > > can you also update cli/execute.cpp, examples/test_http_framework.cpp, > > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, > > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp? > > > >

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-19 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/ --- (Updated April 19, 2016, 3:19 p.m.) Review request for mesos, Adam B, Ben

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review129486 --- can you also update cli/execute.cpp,

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review129484 --- Patch looks great! Reviews applied: [46364] Passed command:

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-18 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review129476 --- Ship it! Ship It! - Klaus Ma On April 19, 2016, 11:28 a.m.,