Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134796 --- Ship it! Ship It! - Vinod Kone On May 24, 2016, 2:38 a.m., h

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-24 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134531 --- Ship it! Ship It! - Tomasz Janiszewski On May 24, 2016, 2:38

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134519 --- Patch looks great! Reviews applied: [47695] Passed command: expo

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 6:31 p.m., Tomasz Janiszewski wrote: > > Hi, @janisz Really appreciate your favour to help test this! Just updated, may you help to review this again? Thank you in advance. - haosdent --- This is an automatically gen

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/ --- (Updated May 24, 2016, 2:38 a.m.) Review request for mesos, Tomasz Janiszewski,

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 6:31 p.m., Tomasz Janiszewski wrote: > > site/README.md, line 12 > > > > > > Running this command will end up with error: `unable to prepare > > context: unable to evaluate symlinks in context path

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134425 --- Patch looks great! Reviews applied: [47695] Passed command: expo

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Tomasz Janiszewski
> On May 23, 2016, 7:50 a.m., Tomasz Janiszewski wrote: > > > > haosdent huang wrote: > Hi, @janisz. Thank you very much for your detail reviews, may you help to > review this patch again? Thank you in advance. Tested. LGTM but I left some minor comments. - Tomasz -

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134408 --- site/README.md (line 9)

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134404 --- support/site-docker/Dockerfile (line 10)

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134403 --- site/Rakefile (line 75)

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134400 --- site/Gemfile.lock (line 100)

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 7:50 a.m., Tomasz Janiszewski wrote: > > Hi, @janisz. Thank you very much for your detail reviews, may you help to review this patch again? Thank you in advance. - haosdent --- This is an automatically generated e-ma

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 7:50 a.m., Tomasz Janiszewski wrote: > > site/Dockerfile, line 1 > > > > > > Why not officail [Ruby image](https://hub.docker.com/_/ruby/) Yes, we could not use it because ruby images based on ubunt

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
> On May 22, 2016, 5:46 p.m., Vinod Kone wrote: > > site/Rakefile, line 5 > > > > > > shouldn't the "build" task happen after "doxygen" and "javadoc"? According my test, there are not differences not matter we put it

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/ --- (Updated May 23, 2016, 5:49 p.m.) Review request for mesos, Tomasz Janiszewski,

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134318 --- site/Dockerfile (line 1)

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134279 --- site/README.md (line 15)

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134265 --- Patch looks great! Reviews applied: [47695] Passed command: expo

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/ --- (Updated May 22, 2016, 10:45 a.m.) Review request for mesos, Tomasz Janiszewski

Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/ --- Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and Vino