Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-08 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: mesos-5491 h

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review136713 --- Patch looks great! Reviews applied: [48438] Passed command: expo

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review136859 --- Hi, @dongdong. Now the return type of RPC handlers become `proces

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review136864 --- Looks great to me. XD include/mesos/v1/mesos.proto (lines 1974 -

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-09 Thread zhou xing
> On 六月 9, 2016, 6:12 p.m., haosdent huang wrote: > > Looks great to me. XD Thanks hasdent for the review! hope some day can meet you in person:) I will update the patch later - zhou --- This is an automatically generated e-mail. To re

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-09 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 10, 2016, 1:16 a.m.) Review request for mesos, Anand Mazumdar and V

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review136965 --- Patch looks great! Reviews applied: [48438] Passed command: expo

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review137032 --- Ship it! Ship It! - haosdent huang On June 10, 2016, 1:16 a.

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-16 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 17, 2016, 6:37 a.m.) Review request for mesos, Anand Mazumdar, haos

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review138188 --- Patch looks great! Reviews applied: [48835, 48841, 48438] Passed

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review138276 --- src/master/http.cpp (line 1699)

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-18 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 18, 2016, 2:02 p.m.) Review request for mesos, Anand Mazumdar, haos

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review138420 --- Patch looks great! Reviews applied: [48835, 48841, 48438] Passed

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review138345 --- src/master/http.cpp (line 1706)

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-19 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 20, 2016, 2:47 a.m.) Review request for mesos, Anand Mazumdar, haos

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review138558 --- Patch looks great! Reviews applied: [48835, 48841, 48438] Passed

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review138621 --- Ship it! Ship It! - haosdent huang On June 20, 2016, 2:47 a.

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review138681 --- Ship it! Ship It! - Vinod Kone On June 20, 2016, 2:47 a.m.,

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-21 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 22, 2016, 1:53 a.m.) Review request for mesos, Anand Mazumdar, haos

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review139040 --- Patch looks great! Reviews applied: [48835, 48841, 48438] Passed

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-27 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 27, 2016, 9:03 a.m.) Review request for mesos, Anand Mazumdar, haos

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review139561 --- Patch looks great! Reviews applied: [48835, 48841, 48438] Passed

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review139586 --- Ship it! Ship It! - haosdent huang On June 27, 2016, 9:03 a.

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review139676 --- Fix it, then Ship it! can you rebase? src/master/http.cpp (li

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-27 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 28, 2016, 1:07 a.m.) Review request for mesos, Anand Mazumdar, haos