Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/#review138359 --- Ship it! I'll make necessary changes and commit this for you.

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/ --- (Updated June 17, 2016, 12:31 a.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

> On June 15, 2016, 6:08 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 987 > > > > > > Is there a guarantee that the plugin would be waiting for the isolator >

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/#review138128 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/#review137868 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

> On June 15, 2016, 6:08 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 967 > > > > > > We should make these keys ("labels", "task-id", "args") as `constexpr` >

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/ --- (Updated June 15, 2016, 10:23 p.m.) Review request for mesos and Jie Yu. Repo

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/ --- (Updated June 15, 2016, 9:41 p.m.) Review request for mesos and Jie Yu. Repos

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/ --- (Updated June 15, 2016, 9:10 p.m.) Review request for mesos and Jie Yu. Repos

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/#review137667 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/#review137448 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/ --- (Updated June 14, 2016, 1:05 a.m.) Review request for mesos. Repository: meso

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/#review136961 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/ --- Review request for mesos. Repository: mesos Description --- Add NetworkI