Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/#review139126 --- Patch looks great! Reviews applied: [48926, 48927, 48938] Passed

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-22 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/ --- (Updated June 22, 2016, 11:28 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/#review139030 --- Bad patch! Reviews applied: [48938, 48927, 48926] Failed command

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/#review139003 --- Ship it! Ship It! - haosdent huang On June 22, 2016, 12:53 a

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/ --- (Updated June 22, 2016, 12:53 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/#review138914 --- Ship it! Can you rebase? - Vinod Kone On June 21, 2016, 12:1

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/#review138837 --- Bad patch! Reviews applied: [48938, 48927, 48926] Failed command

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/ --- (Updated June 21, 2016, 12:12 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-21 Thread Shuai Lin
> On June 20, 2016, 5:36 p.m., haosdent huang wrote: > > src/tests/api_tests.cpp, line 765 > > > > > > Insert a blank line below, refer to > > https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/#review138705 --- src/internal/evolve.cpp (line 163)

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/#review138645 --- Patch looks great! Reviews applied: [48926, 48927, 48938] Passed

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/#review138642 --- src/tests/api_tests.cpp (line 765)

Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-19 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5502 https://issues.ap