Re: Review Request 49688: Added cmake build for mesos tests.

> On July 12, 2016, 4:23 a.m., Alex Clemmer wrote: > > src/tests/CMakeLists.txt, line 156 > > > > > > Also, I think this is not the right command to run for Mesos tests -- > > can you confirm? The same goes for the

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 12, 2016, 4:26 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build for mesos tests.

> On July 12, 2016, 4:16 a.m., Alex Clemmer wrote: > > src/tests/CMakeLists.txt, line 71 > > > > > > Can we please use the Mesos style TODO format? Specifically: > > > > * add semicolons after the

Re: Review Request 49688: Added cmake build for mesos tests.

> On July 12, 2016, 4:16 a.m., Alex Clemmer wrote: > > src/tests/CMakeLists.txt, line 71 > > > > > > Can we please use the Mesos style TODO format? Specifically: > > > > * add semicolons after the

Re: Review Request 49688: Added cmake build for mesos tests.

> On July 12, 2016, 4:16 a.m., Alex Clemmer wrote: > > src/tests/CMakeLists.txt, line 71 > > > > > > Can we please use the Mesos style TODO format? Specifically: > > > > * add semicolons after the

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review141840 --- src/tests/CMakeLists.txt (line 156)

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review141822 --- cmake/MesosConfigure.cmake (line 94)

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 11, 2016, 3:46 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 10, 2016, 2:10 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 10, 2016, 1:49 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build for mesos tests.

> On July 6, 2016, 4:17 p.m., Joseph Wu wrote: > > src/tests/CMakeLists.txt, line 17 > > > > > > It does look like this MesosTestConfigure thing is unused, but I'll > > need to double-check with Alex Clemmer. We

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 10, 2016, 1 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review141011 --- CMakeLists.txt (lines 110 - 115)

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review140974 --- Patch looks great! Reviews applied: [49688] Passed command:

Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792