Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.

2016-07-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49841/#review141726 --- Ship it! Ship It! - Avinash sridharan On July 8, 2016,

Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.

2016-07-11 Thread Jie Yu
> On July 11, 2016, 2:46 p.m., Qian Zhang wrote: > > So even we reorganize the routing tests into basic and advanced groups, all > > these tests are still in the same file (routing_tests.cpp which is > > currently guarded by `WITH_NETWORK_ISOLATOR` in Makefile.am) which means > > they will be

Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.

2016-07-11 Thread Jie Yu
> On July 11, 2016, 3:42 p.m., Avinash sridharan wrote: > > src/tests/containerizer/routing_tests.cpp, line 258 > > > > > > Instead of failing over here should we be disabling these tests if the > > libnl version

Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.

2016-07-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49841/#review141706 --- src/tests/containerizer/routing_tests.cpp (line 207)

Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.

2016-07-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49841/#review141691 --- So even we reorganize the routing tests into basic and advanced

Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.

2016-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49841/#review141392 --- Patch looks great! Reviews applied: [49835, 49839, 49840, 49841]

Review Request 49841: Reorganized the routing tests into basic and advanced groups.

2016-07-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49841/ --- Review request for mesos, Avinash sridharan and Qian Zhang. Repository: mesos