Review Request 52754: Remove unused code which now throws errors with the new hardening flags

2016-10-11 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/ --- Review request for mesos and Michael Park. Bugs: MESOS-6239 https://issues.

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

2016-10-24 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/#review153715 --- 3rdparty/libprocess/src/profiler.cpp

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

2016-10-25 Thread Aaron Wood
> On Oct. 24, 2016, 6 p.m., James Peach wrote: > > 3rdparty/libprocess/src/profiler.cpp, line 35 > > > > > > Why remove this? It looks like it is actually used? You're right, it does look like it's used. Without remo

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

2016-10-25 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/ --- (Updated Oct. 25, 2016, 8:32 p.m.) Review request for mesos, James Peach, Micha

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

2016-11-01 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/#review154467 --- Ship it! This looks fine, but consider reordering this patch so

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

2016-11-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/#review154535 --- Fix it, then Ship it! 3rdparty/libprocess/src/profiler.cpp (li

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

2016-11-07 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/ --- (Updated Nov. 7, 2016, 3:51 p.m.) Review request for mesos, James Peach, Michae

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

2016-11-08 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/ --- (Updated Nov. 8, 2016, 5:38 p.m.) Review request for mesos, James Peach, Michae

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

2016-11-08 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/ --- (Updated Nov. 8, 2016, 5:39 p.m.) Review request for mesos, James Peach, Michae

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

2016-11-08 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/ --- (Updated Nov. 8, 2016, 5:40 p.m.) Review request for mesos, James Peach, Michae

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

2016-11-17 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/#review156251 --- Ship it! Ship It! - Michael Park On Nov. 8, 2016, 9:40 a.m.,