Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/ --- (Updated Nov. 18, 2016, 4:27 p.m.) Review request for mesos, James Peach,

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/#review156240 --- Fix it, then Ship it! 3rdparty/stout/tests/json_tests.cpp

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/ --- (Updated Nov. 8, 2016, 5:39 p.m.) Review request for mesos, James Peach,

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

> On Nov. 2, 2016, 10:54 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/tests/json_tests.cpp, line 175 > > > > > > Not yours, but the ordering of parameters (should be `expected, > > actual`) is wrong here and in

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/ --- (Updated Nov. 7, 2016, 4:11 p.m.) Review request for mesos, James Peach,

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

> On Nov. 2, 2016, 9:54 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/tests/json_tests.cpp, line 175 > > > > > > Not yours, but the ordering of parameters (should be `expected, > > actual`) is wrong here and in

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/#review154529 --- Fix it, then Ship it! Looks great, thanks a lot for cleaning

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/#review154440 --- Ship it! Ship It! - James Peach On Oct. 27, 2016, 7:32

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/ --- (Updated Oct. 27, 2016, 7:32 p.m.) Review request for mesos, James Peach,

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

> On Oct. 17, 2016, 3:39 p.m., James Peach wrote: > > 3rdparty/stout/tests/ip_tests.cpp, line 50 > > > > > > Probably better to just use the same type here. Since > > ``network.get().prefix()`` returns ``int``,

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/#review152886 --- 3rdparty/stout/tests/ip_tests.cpp (line 50)

Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/ --- Review request for mesos, Michael Park and Neil Conway. Bugs: MESOS-6239