Re: Review Request 54038: Added new hook for covering executor and task environment.

2016-11-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/ --- (Updated Nov. 25, 2016, 9:37 p.m.) Review request for mesos, Adam B, Gastón

Re: Review Request 54038: Added new hook for covering executor and task environment.

2016-11-25 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/#review156918 --- Fix it, then Ship it! Just a few typos, but it looks good to

Re: Review Request 54038: Added new hook for covering executor and task environment.

2016-11-24 Thread Till Toenshoff
> On Nov. 24, 2016, 3:38 a.m., Adam B wrote: > > include/mesos/hook.hpp, line 111 > > > > > > "Deprecated"? Will we ever remove this hook? I was discussing this with Kapil and we need to address this very soon.

Re: Review Request 54038: Added new hook for covering executor and task environment.

2016-11-24 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/ --- (Updated Nov. 25, 2016, 4:10 a.m.) Review request for mesos, Adam B, Gastón

Re: Review Request 54038: Added new hook for covering executor and task environment.

2016-11-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/#review156827 --- Patch looks great! Reviews applied: [54038] Passed command:

Re: Review Request 54038: Added new hook for covering executor and task environment.

2016-11-23 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/#review156809 --- Fix it, then Ship it! Looks good. I've got some

Re: Review Request 54038: Added new hook for covering executor and task environment.

2016-11-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/#review156778 --- Fix it, then Ship it! include/mesos/hook.hpp (line 136)

Re: Review Request 54038: Added new hook for covering executor and task environment.

2016-11-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/#review156777 --- Ship it! Ship It! - Kapil Arya On Nov. 23, 2016, 2:26 p.m.,

Review Request 54038: Added new hook for covering executor and task environment.

2016-11-23 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/ --- Review request for mesos, Adam B, Gastón Kleiman, Kapil Arya, and Joseph Wu.