Re: Review Request 54291: Added os::ptsname to stout.

2016-12-05 Thread Benjamin Bannier
> On Dec. 2, 2016, 10:16 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/posix/os.hpp, line 480 > > > > > > We should be able to use a simple function-local static here and avoid > > the global leak

Re: Review Request 54291: Added os::ptsname to stout.

2016-12-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/ --- (Updated Dec. 5, 2016, 5:34 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54291: Added os::ptsname to stout.

2016-12-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/#review157953 --- Ship it! Ship It! - Kevin Klues On Dec. 2, 2016, 6:29 p.m.,

Re: Review Request 54291: Added os::ptsname to stout.

2016-12-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/#review157948 --- Ship it! Adding the TODO for `ptsname_r` on Linux SGTM as well

Re: Review Request 54291: Added os::ptsname to stout.

2016-12-04 Thread Jie Yu
> On Dec. 2, 2016, 9:16 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/posix/os.hpp, line 480 > > > > > > We should be able to use a simple function-local static here and avoid > > the global leak

Re: Review Request 54291: Added os::ptsname to stout.

2016-12-02 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/#review157800 --- 3rdparty/stout/include/stout/posix/os.hpp (line 480)

Re: Review Request 54291: Added os::ptsname to stout.

2016-12-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/ --- (Updated Dec. 2, 2016, 6:29 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54291: Added os::ptsname to stout.

2016-12-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/#review157711 --- 3rdparty/stout/include/stout/posix/os.hpp (line 480)

Review Request 54291: Added os::ptsname to stout.

2016-12-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Repository: mesos