Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/#review158161 --- src/tests/master_tests.cpp (line 4995)

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/ --- (Updated Dec. 6, 2016, 1:58 p.m.) Review request for mesos, Benjamin Mahler, Gu

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/ --- (Updated Dec. 6, 2016, 1:47 p.m.) Review request for mesos, Benjamin Mahler, Gu

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/#review158143 --- The test case in `Testing Done` section should be udpated to `Add

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

> On 十二月 6, 2016, 12:52 a.m., Guangya Liu wrote: > > src/tests/master_tests.cpp, line 4992 > > > > > > EXPECT_SOME_EQ(expected.get(), parse); > > Jay Guo wrote: > We already did `ASSERT_SOME(parse)` when we get

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/ --- (Updated Dec. 6, 2016, 3:05 a.m.) Review request for mesos, Benjamin Mahler, Gu

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

> On Dec. 6, 2016, 12:52 a.m., Guangya Liu wrote: > > src/tests/master_tests.cpp, line 4957 > > > > > > When this role was added? https://github.com/apache/mesos/blob/master/src/master/http.cpp#L3254-L3268 Default

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/#review158089 --- src/tests/master_tests.cpp (line 4917)

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/#review157965 --- Patch looks great! Reviews applied: [54359, 54360, 54361] Passed

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/ --- (Updated Dec. 5, 2016, 6:13 a.m.) Review request for mesos, Benjamin Mahler, Gu

Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, and Qiang Zhang. Bugs: