Re: Review Request 55030: CMake: Added source groups for libprocess build.

2017-02-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55030/ --- (Updated Feb. 13, 2017, 11:04 p.m.) Review request for mesos, Andrew

Re: Review Request 55030: CMake: Added source groups for libprocess build.

2017-01-28 Thread Alex Clemmer
> On Jan. 25, 2017, 12:29 a.m., Joseph Wu wrote: > > This review is partially un-done by https://reviews.apache.org/r/55604/ . > > Can you separate the source-grouping changes into > > https://reviews.apache.org/r/55604/ ? And leave the CMake lists > > rearrangement in this review? We

Re: Review Request 55030: CMake: Added source groups for libprocess build.

2017-01-28 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55030/ --- (Updated Jan. 29, 2017, 7:18 a.m.) Review request for mesos, Andrew

Re: Review Request 55030: CMake: Added source groups for libprocess build.

2017-01-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55030/#review162883 --- This review is partially un-done by

Re: Review Request 55030: CMake: Added source groups for libprocess build.

2017-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55030/ --- (Updated Jan. 15, 2017, 8:47 a.m.) Review request for mesos, Andrew

Re: Review Request 55030: CMake: Added source groups for libprocess build.

2017-01-11 Thread Alex Clemmer
> On Jan. 11, 2017, 10:23 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/tests/CMakeLists.txt, lines 80-81 > > > > > > What's the effect of adding these `source_groups` in multiple CMake > > lists? > > > >

Re: Review Request 55030: CMake: Added source groups for libprocess build.

2017-01-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55030/#review161306 --- 3rdparty/libprocess/cmake/ProcessConfigure.cmake (lines 59 - 72)

Review Request 55030: CMake: Added source groups for libprocess build.

2016-12-24 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55030/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich,