Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-11-17 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review191417 --- Ship it! Ship It! - Gilbert Song On Nov. 17, 2017, 8:52

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-11-17 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated Nov. 17, 2017, 4:52 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-11-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review191280 --- src/tests/containerizer/mesos_containerizer_tests.cpp Lines

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-11-10 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated Nov. 10, 2017, 7:31 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-11-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review190225 --- Fix it, then Ship it!

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-10-27 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated Oct. 27, 2017, 6:01 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-10-26 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review189345 --- src/tests/containerizer/mesos_containerizer_tests.cpp Lines

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-10-26 Thread Gilbert Song
> On Sept. 25, 2017, 6:23 p.m., Gilbert Song wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp > > Line 714 (original), 714-720 (patched) > > > > > > will it look cleaner if use `createTask()` helper?

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-10-19 Thread Zhitao Li
> On Sept. 26, 2017, 1:23 a.m., Gilbert Song wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp > > Line 714 (original), 714-720 (patched) > > > > > > will it look cleaner if use `createTask()` helper?

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-09-26 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated Sept. 26, 2017, 8:14 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-09-26 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated Sept. 26, 2017, 6:13 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-09-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review186191 --- src/tests/containerizer/mesos_containerizer_tests.cpp Line 714

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-08-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated Aug. 1, 2017, 5:10 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-05-31 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated May 31, 2017, 5:57 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-02-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated Feb. 15, 2017, 9:14 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-01-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review160885 --- Patch looks great! Reviews applied: [55334, 55335] Passed

Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

2017-01-09 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. Bugs: