Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review162361 --- Patch looks great! Reviews applied: [55676, 55722, 55677, 55678,

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-19 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/ --- (Updated Jan. 19, 2017, 4:37 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-19 Thread Anand Mazumdar
> On Jan. 19, 2017, 3:20 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 3896 > > > > > > Maybe also verify parent container is still running. > > > > ``` > > EXPECT_TRUE(waitParent.isPending(

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review162297 --- Fix it, then Ship it! Modulo other comments from Vinod src/sl

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review162292 --- Fix it, then Ship it! src/tests/api_tests.cpp (line 3644)

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-18 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review162210 --- Patch looks great! Reviews applied: [55676, 55677, 55678, 55679,

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-18 Thread Gastón Kleiman
> On Jan. 16, 2017, 7:33 p.m., Anand Mazumdar wrote: > > src/slave/http.cpp, line 2184 > > > > > > Not yours, but we should rename this to `getExecutor(...)` to be > > consistent with other similar functions in the

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-18 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/ --- (Updated Jan. 18, 2017, 2:48 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-16 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review161753 --- Looks good for the most part! Mostly minor cleanup comments. src

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-13 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/ --- (Updated Jan. 13, 2017, 1:52 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review161515 --- Patch looks great! Reviews applied: [55463, 55464] Passed comman

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-13 Thread Gastón Kleiman
> On Jan. 12, 2017, 3:50 p.m., Alexander Rojas wrote: > > src/tests/api_tests.cpp, lines 3619-3659 > > > > > > Why not replacing this test with one that shows the opposite? I added a test that launches parent and c

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-13 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/ --- (Updated Jan. 13, 2017, 10:08 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review161401 --- Bad patch! Reviews applied: [55464, 55463] Failed command: pytho

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review161391 --- src/tests/api_tests.cpp

Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

2017-01-12 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/ --- Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander