Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

2017-01-27 Thread Alex Clemmer
> On Jan. 25, 2017, 12:27 a.m., Joseph Wu wrote: > > 3rdparty/stout/cmake/StoutConfigure.cmake, line 47 > > > > > > Why not use `*.hpp` instead? > > Alex Clemmer wrote: > Generally, we also would like to include

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

2017-01-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55600/#review163216 --- Ship it! Ship It! - Joseph Wu On Jan. 16, 2017, 10:41 p.m.,

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

2017-01-26 Thread Joseph Wu
> On Jan. 24, 2017, 4:27 p.m., Joseph Wu wrote: > > 3rdparty/stout/cmake/StoutConfigure.cmake, line 47 > > > > > > Why not use `*.hpp` instead? > > Alex Clemmer wrote: > Generally, we also would like to include

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

2017-01-26 Thread Joseph Wu
> On Jan. 24, 2017, 4:27 p.m., Joseph Wu wrote: > > 3rdparty/stout/cmake/StoutConfigure.cmake, line 47 > > > > > > Why not use `*.hpp` instead? > > Alex Clemmer wrote: > Generally, we also would like to include

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

2017-01-26 Thread Alex Clemmer
> On Jan. 25, 2017, 12:27 a.m., Joseph Wu wrote: > > 3rdparty/stout/cmake/StoutConfigure.cmake, line 47 > > > > > > Why not use `*.hpp` instead? Generally, we also would like to include .h files generated by

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

2017-01-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55600/#review162882 --- 3rdparty/stout/cmake/StoutConfigure.cmake (line 47)

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

2017-01-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55600/ --- (Updated Jan. 17, 2017, 6:41 a.m.) Review request for mesos, Andrew

Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

2017-01-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55600/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.