Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-12-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review194533 --- Fix it, then Ship it! include/mesos/agent/agent.proto Lines 97

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-12-26 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review194516 --- src/slave/http.cpp Lines 2452 (patched)

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-12-26 Thread Gilbert Song
> On Dec. 22, 2017, 7:34 p.m., Gilbert Song wrote: > > src/slave/http.cpp > > Lines 2452 (patched) > > > > > > As we discussed offline, we should follow the semantic that if there > > are excluded images from the a

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-12-24 Thread Zhitao Li
> On Dec. 23, 2017, 3:34 a.m., Gilbert Song wrote: > > src/slave/http.cpp > > Lines 2452 (patched) > > > > > > As we discussed offline, we should follow the semantic that if there > > are excluded images from the a

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-12-24 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/ --- (Updated Dec. 24, 2017, 7:31 p.m.) Review request for mesos, Gilbert Song, Jaso

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-12-22 Thread Gilbert Song
> On Dec. 22, 2017, 3:55 p.m., Jie Yu wrote: > > @gilbert, @zhitao, is this a 1.5.0 blocker? Do we want to land this? yes, but we still have one small issue to address. I will cherrypick it to the 1.5.x branch. thanks! - Gilbert --- Th

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-12-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review194469 --- src/slave/http.cpp Lines 2452 (patched)

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-12-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review194466 --- @gilbert, @zhitao, is this a 1.5.0 blocker? Do we want to land thi

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-12-22 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/ --- (Updated Dec. 22, 2017, 8:10 p.m.) Review request for mesos, Gilbert Song, Jaso

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-11-22 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/ --- (Updated Nov. 22, 2017, 10:50 p.m.) Review request for mesos, Gilbert Song, Jas

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-11-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review191540 --- Fix it, then Ship it! include/mesos/v1/agent/agent.proto Lines

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-11-17 Thread Zhitao Li
> On Nov. 17, 2017, 1:24 a.m., Gilbert Song wrote: > > src/slave/http.cpp > > Lines 2302-2304 (patched) > > > > > > one thing to notice is that the current interface returns > > `Future`, so we dont have a way to d

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-11-17 Thread Zhitao Li
> On Nov. 17, 2017, 1:24 a.m., Gilbert Song wrote: > > src/slave/http.cpp > > Lines 2299 (patched) > > > > > > instead of passing in the `acceptType`, we might want to pass the > > containerId and construct the err

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-11-17 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/ --- (Updated Nov. 17, 2017, 4:48 p.m.) Review request for mesos, Gilbert Song, Jaso

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-11-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review191277 --- src/slave/http.hpp Lines 306 (patched)

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-11-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/ --- (Updated Nov. 16, 2017, 4:03 a.m.) Review request for mesos, Gilbert Song, Jaso

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-10-09 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/ --- (Updated Oct. 9, 2017, 11:18 p.m.) Review request for mesos, Gilbert Song, Jaso