Re: Review Request 59950: Added tests for `DefaultExecutor` setting `MESOS_CONTAINER_IP`.

2017-06-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59950/#review178061 --- src/tests/containerizer/cni_isolator_tests.cpp Lines 1330

Re: Review Request 59950: Added tests for `DefaultExecutor` setting `MESOS_CONTAINER_IP`.

2017-06-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59950/#review178063 --- Fix it, then Ship it!

Re: Review Request 59950: Added tests for `DefaultExecutor` setting `MESOS_CONTAINER_IP`.

2017-06-14 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59950/ --- (Updated June 15, 2017, 12:41 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 59950: Added tests for `DefaultExecutor` setting `MESOS_CONTAINER_IP`.

2017-06-14 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59950/ --- (Updated June 14, 2017, 9:58 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 59950: Added tests for `DefaultExecutor` setting `MESOS_CONTAINER_IP`.

2017-06-13 Thread Avinash sridharan
> On June 13, 2017, 9:08 p.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 1241 (patched) > > > > > > do you need `mesos::` prefix here? Yeah without `mesos` the compiler tries to

Re: Review Request 59950: Added tests for `DefaultExecutor` setting `MESOS_CONTAINER_IP`.

2017-06-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59950/#review177796 --- Fix it, then Ship it!

Re: Review Request 59950: Added tests for `DefaultExecutor` setting `MESOS_CONTAINER_IP`.

2017-06-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59950/#review177510 --- Patch looks great! Reviews applied: [59949, 59950] Passed

Review Request 59950: Added tests for `DefaultExecutor` setting `MESOS_CONTAINER_IP`.

2017-06-09 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59950/ --- Review request for mesos, Anand Mazumdar and Jie Yu. Bugs: MESOS-7631