Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 19, 2017, 2:13 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 437 (patched) > > > > > > I think we need to introduce a new reason > >

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 19, 2017, 6:13 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 437 (patched) > > > > > > I think we need to introduce a new reason > >

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 19, 2017, 2:13 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 437 (patched) > > > > > > I think we need to introduce a new reason > >

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 19, 2017, 6:13 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 437 (patched) > > > > > > I think we need to introduce a new reason > >

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review185660 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 16, 2017, 11 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 421-424 (patched) > > > > > > I did some experiments and found when I launch a comman task

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review185649 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated Sept. 19, 2017, 12:20 a.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 16, 2017, 3 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 421-424 (patched) > > > > > > We need to log this message like what we did here: > > > >

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 16, 2017, 3 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 421-424 (patched) > > > > > > I did some experiments and found when I launch a comman task

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review185517 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review184958 --- Ship it! Ship It! - Qian Zhang On Sept. 8, 2017, 8:09 a.m.,

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 5, 2017, 7:12 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 271-284 (patched) > > > > > > Mind to explain why running the loop inside the isolator

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 17, 2017, 2:45 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 148-150 (patched) > > > > > > It seems we only care about `port`, so it might not be needed

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated Sept. 8, 2017, 12:09 a.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 5, 2017, 3:12 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 271-284 (patched) > > > > > > Mind to explain why running the loop inside the isolator

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated Sept. 5, 2017, 5:39 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 5, 2017, 7:12 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 271-284 (patched) > > > > > > Mind to explain why running the loop inside the isolator

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 24, 2017, 10:53 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 200-202 (original), 373-375 (patched) > > > > > > When framework launches a task group, this

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review184492 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated Aug. 30, 2017, 11:19 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 24, 2017, 2:53 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 200-202 (original), 373-375 (patched) > > > > > > When framework launches a task group, this

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 24, 2017, 7:17 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 298 (patched) > > > > > > We do not need `process::` since you already have `using > >

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 18, 2017, 2:39 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 66-67 (patched) > > > > > > Usually when we define a `xxxProcess` class, we want it to do some

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 18, 2017, 10:39 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 66-67 (patched) > > > > > > Usually when we define a `xxxProcess` class, we want it to do

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review183709 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review183696 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated Aug. 23, 2017, 8:29 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated Aug. 18, 2017, 9 p.m.) Review request for mesos, Qian Zhang and Jiang

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 18, 2017, 2:39 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 362 (patched) > > > > > > I see you put the actual used resources (i.e. unallocated ports)

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 18, 2017, 2:39 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 66-67 (patched) > > > > > > Usually when we define a `xxxProcess` class, we want it to do some

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review183190 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 17, 2017, 10:45 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 156-157 (patched) > > > > > > Do we really need this? I think showing pid like what you did

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 17, 2017, 2:45 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.hpp > > Lines 39 (patched) > > > > > > Should be a `static` variable. > > > > Or do we want to make

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated Aug. 17, 2017, 5:36 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review182691 --- src/slave/containerizer/mesos/isolators/network/ports.hpp Lines

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated July 17, 2017, 12:04 a.m.) Review request for mesos, Qian Zhang and