Re: Review Request 61182: Sent a resource provider message when providers subscribe.

2017-07-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61182/#review181734 --- src/resource_provider/message.hpp Lines 29 (patched)

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

2017-07-31 Thread Jie Yu
> On July 28, 2017, 10:03 p.m., Jie Yu wrote: > > src/resource_provider/message.hpp > > Lines 29 (patched) > > > > > > With ERP in mind, maybe it's more approapriate to make this message for > > a single resource pro

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

2017-08-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61182/ --- (Updated Aug. 1, 2017, 7:42 p.m.) Review request for mesos, Jie Yu and Jan Schl

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

2017-08-08 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61182/#review182387 --- Looks great, only nitpicking here. Please rebase, `resource_provid

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

2017-08-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61182/#review183197 --- Can you rebase? - Jie Yu On Aug. 1, 2017, 5:42 p.m., Benjamin B

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

2017-09-06 Thread Benjamin Bannier
> On Aug. 1, 2017, 12:48 a.m., Jie Yu wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 134 (patched) > > > > > > In fact, what's the different between this and > > ResourceProviderHttpApiTest.Subsc

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

2017-09-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61182/ --- (Updated Sept. 6, 2017, 1:59 p.m.) Review request for mesos, Jie Yu and Jan Sch

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

2017-09-06 Thread Benjamin Bannier
> On Aug. 8, 2017, 3:53 p.m., Jan Schlicht wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 383 (patched) > > > > > > Nit: Use `v1::ResourceProviderInfo` instead of > > `mesos::v1::ResourceProvider

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

2017-09-06 Thread Jan Schlicht
> On Aug. 8, 2017, 3:53 p.m., Jan Schlicht wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 383 (patched) > > > > > > Nit: Use `v1::ResourceProviderInfo` instead of > > `mesos::v1::ResourceProvider

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

2017-09-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61182/#review184746 --- Ship it! Ship It! - Jie Yu On Sept. 6, 2017, 11:59 a.m., Ben