Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

2017-11-02 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/ --- (Updated Nov. 2, 2017, 12:52 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

2017-11-01 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/#review189861 --- Per offline discussion, looks like we don't actually need to be

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

2017-11-01 Thread Gaston Kleiman
> On Oct. 31, 2017, 3:43 p.m., Benjamin Mahler wrote: > > src/tests/master_slave_reconciliation_tests.cpp > > Lines 721 (patched) > > > > > > TaskExecutorIds? Renamed in RR 63474. - Gaston

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

2017-11-01 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/ --- (Updated Nov. 1, 2017, 1:53 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

2017-10-31 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/#review189780 --- PASS: Mesos patch 63353 was successfully built and tested.

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

2017-10-31 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/#review189761 --- Fix it, then Ship it! Can you split the fix and the test? We

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

2017-10-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/#review189410 --- Patch looks great! Reviews applied: [63353] Passed command:

Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

2017-10-27 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/ --- Review request for mesos, Benjamin Mahler and Greg Mann. Bugs: MESOS-8135