Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/ --- (Updated Nov. 27, 2017, 10:43 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191869 --- Ship it! src/checks/tcp_connect.cpp Lines 33-34 (patched)

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/ --- (Updated Nov. 27, 2017, 10:20 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

> On Nov. 25, 2017, 11:49 a.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Lines 88 (patched) > > > > > > Why do we need this? `net::IP` will always be `AF_INET` or `AF_INET6`? > > Qian Zhang wrote:

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

> On Nov. 25, 2017, 7:49 p.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Lines 88 (patched) > > > > > > Why do we need this? `net::IP` will always be `AF_INET` or `AF_INET6`? That's from Alex's comm

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191849 --- Fix it, then Ship it! Ship It! src/checks/tcp_connect.cpp Lin

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

> On Nov. 22, 2017, 8:16 p.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Lines 90 (patched) > > > > > > Should have bought this up earlier. I think this code will be a lot > > more simpler if you us

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/ --- (Updated Nov. 22, 2017, 11:14 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191722 --- src/checks/tcp_connect.cpp Lines 90 (patched)

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

> On Nov. 16, 2017, 6:54 p.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Lines 90 (patched) > > > > > > Why do we need this? > > > > `net::IP::in` and `net::IP::in6` already give this functi

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/ --- (Updated Nov. 17, 2017, 8:57 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

> On Nov. 17, 2017, 2:54 a.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Lines 90 (patched) > > > > > > Why do we need this? > > > > `net::IP::in` and `net::IP::in6` already give this functi

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

> On Nov. 16, 2017, 6:54 p.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Line 86 (original), 84 (patched) > > > > > > `AF_UNSPEC` is default. You can just do `net::IP::parse` > > > > Also in

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191196 --- src/checks/tcp_connect.cpp Line 86 (original), 84 (patched)

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/ --- (Updated Nov. 16, 2017, 3:21 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191133 --- src/checks/tcp_connect.cpp Line 86 (original), 84 (patched)

Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/ --- Review request for mesos, Alexander Rukletsov and Avinash sridharan. Bugs: MESO