Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

> On Nov. 28, 2017, 7:44 p.m., Alexander Rukletsov wrote: > > Surprisingly hard to review the diff Yeah, In `src/tests/health_check_tests.cpp`, I only removed 3 existing tests, and added 3 new tests, but did not change any other tests. I am not sure why the code diff of this patch is generated

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review192015 --- Ship it! Surprisingly hard to review the diff - Alexander Rukl

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

> On Nov. 28, 2017, 6 p.m., Alexander Rukletsov wrote: > > src/tests/health_check_tests.cpp > > Lines 2227 (patched) > > > > > > This is invoked regardless of the fixture parameter. Is this on > > purpose? Is it no

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

> On Nov. 27, 2017, 6:03 p.m., Alexander Rukletsov wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 4963-4964 (original), 4936-4937 (patched) > > > > > > Swap these lines We need to remov

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/ --- (Updated Nov. 28, 2017, 7:12 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review192007 --- src/tests/health_check_tests.cpp Lines 2227 (patched)

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review191871 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines 4963

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

> On Nov. 18, 2017, 3:25 a.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Lines 2450 (patched) > > > > > > We should try and see if we can publish this image to > > :https://hub.docker.com/u/

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review191724 --- Ship it! Ship It! - Avinash sridharan On Nov. 19, 2017, 1:41

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

> On Nov. 17, 2017, 7:25 p.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Lines 2450 (patched) > > > > > > We should try and see if we can publish this image to > > :https://hub.docker.com/u/

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review191457 --- PASS: Mesos patch 63910 was successfully built and tested. Review

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/ --- (Updated Nov. 19, 2017, 9:41 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

> On Nov. 18, 2017, 3:25 a.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Lines 1972 (patched) > > > > > > What is `local mode`? :) That is not something added or modified in this patch :-) I

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review191375 --- src/tests/health_check_tests.cpp Lines 1972 (patched)

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review191360 --- PASS: Mesos patch 63910 was successfully built and tested. Review

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/ --- (Updated Nov. 17, 2017, 9:35 p.m.) Review request for mesos, Alexander Rukletso

Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/ --- Review request for mesos, Alexander Rukletsov and Avinash sridharan. Bugs: MESO