Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-13 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review193771 --- Fix it, then Ship it! include/mesos/resource_provider/volume_p

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review193065 --- Ship it! Ship It! - Jie Yu On Dec. 6, 2017, 11:50 p.m., Jose

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/ --- (Updated Dec. 6, 2017, 3:50 p.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Jie Yu
> On Dec. 6, 2017, 6:37 p.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 92 (patched) > > > > > > We chatted about having an ability to define a default profile. To > > support tha

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Joseph Wu
> On Dec. 6, 2017, 12:04 p.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 104-105 (patched) > > > > > > Do we intend to use this module for all LRPs on the agent? If yes, how > >

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Joseph Wu
> On Dec. 6, 2017, 10:37 a.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 92 (patched) > > > > > > We chatted about having an ability to define a default profile. To > > support th

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Jie Yu
> On Dec. 6, 2017, 8:04 p.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 104-105 (patched) > > > > > > Do we intend to use this module for all LRPs on the agent? If yes, how > > c

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Jie Yu
> On Dec. 6, 2017, 8:04 p.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 104-105 (patched) > > > > > > Do we intend to use this module for all LRPs on the agent? If yes, how > > c

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Joseph Wu
> On Dec. 6, 2017, 12:04 p.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 104-105 (patched) > > > > > > Do we intend to use this module for all LRPs on the agent? If yes, how > >

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review193055 --- include/mesos/resource_provider/volume_profile.hpp Lines 106 (pat

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/ --- (Updated Dec. 6, 2017, 3:37 p.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Jie Yu
> On Dec. 6, 2017, 8:04 p.m., Jie Yu wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 104-105 (patched) > > > > > > Do we intend to use this module for all LRPs on the agent? If yes, how > > c

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review193036 --- include/mesos/resource_provider/volume_profile.hpp Lines 104-105

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review193013 --- include/mesos/resource_provider/volume_profile.hpp Lines 34 (patc

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-12-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/ --- (Updated Dec. 5, 2017, 2:06 p.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review192183 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 1402 (pa

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-11-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/ --- (Updated Nov. 29, 2017, 2:34 p.m.) Review request for mesos, Chun-Hung Hsiao an

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-11-27 Thread Joseph Wu
> On Nov. 27, 2017, 3:14 p.m., Chun-Hung Hsiao wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 28 (patched) > > > > > > Currently the CSI spec is internal (under `src/`). Do we want to expose

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-11-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review191944 --- include/mesos/resource_provider/volume_profile.hpp Lines 28 (patc

Review Request 63971: Defined a module interface for translating volume profiles.

2017-11-27 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/ --- Review request for mesos, Chun-Hung Hsiao and Jie Yu. Bugs: MESOS-8251 http