Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review192902 --- Ship it! Ship It! - Vinod Kone On Dec. 4, 2017, 3:28 p.m.,

Re: Review Request 64009: Added new UpdateSlave registry operation.

> On Nov. 28, 2017, 12:37 a.m., Benjamin Mahler wrote: > > src/master/registry_operations.cpp > > Lines 64-70 (patched) > > > > > > Hm.. couldn't we normalize the info resources in the agent and master > > rather

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/ --- (Updated Dec. 4, 2017, 3:28 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review192530 --- Fix it, then Ship it! src/master/registry_operations.cpp Line

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/ --- (Updated Dec. 1, 2017, 6:37 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64009: Added new UpdateSlave registry operation.

> On Nov. 29, 2017, 4:30 p.m., Michael Park wrote: > > I think the fact that `UpdateSlave` gets a `SlaveInfo` in the old format is > > due > > to the fact that we don't upgrade those resources in the master until we > > get to > > the `Slave` struct ctors, as well as the fact that the agents

Re: Review Request 64009: Added new UpdateSlave registry operation.

> On Nov. 29, 2017, 4:30 p.m., Michael Park wrote: > > I think the fact that `UpdateSlave` gets a `SlaveInfo` in the old format is > > due > > to the fact that we don't upgrade those resources in the master until we > > get to > > the `Slave` struct ctors, as well as the fact that the agents

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/ --- (Updated Nov. 29, 2017, 6:06 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review192128 --- I think the fact that `UpdateSlave` gets a `SlaveInfo` in the old

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review191960 --- src/master/registry_operations.cpp Lines 64-70 (patched)

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review191953 --- src/tests/registrar_tests.cpp Lines 270 (patched)

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/ --- (Updated Nov. 27, 2017, 11:29 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review191677 --- src/master/registry_operations.hpp Lines 67 (patched)

Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/ --- Review request for mesos and Vinod Kone. Repository: mesos Description