Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

2018-01-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65261/#review196185 --- Fix it, then Ship it!

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

2018-01-24 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65261/#review196156 --- FAIL: Mesos tests failed to build. Reviews applied: `['65317',

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

2018-01-24 Thread Andrei Budnik
> On Jan. 23, 2018, 3:12 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/paths.hpp > > Lines 147-149 (patched) > > > > > > Let's find a more descriptive word for this, "temp" can mean anything. >

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

2018-01-23 Thread Alexander Rukletsov
> On Jan. 23, 2018, 3:12 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 842-843 (original), 845-852 (patched) > > > > > > If you add an override for

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

2018-01-23 Thread Andrei Budnik
> On Jan. 23, 2018, 3:12 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 842-843 (original), 845-852 (patched) > > > > > > If you add an override for

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

2018-01-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65261/#review196009 --- Great idea, Andrei: clever yet clear and clean. We can ship this

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

2018-01-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65261/#review195902 --- PASS: Mesos patch 65261 was successfully built and tested.

Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

2018-01-22 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65261/ --- Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues. Bugs: