Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/ --- (Updated March 14, 2018, 1:03 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review199095 --- Ship it! Ship It! - Greg Mann On March 7, 2018, 11:36 a.m.,

Re: Review Request 65591: Explicitly tracked resource providers in master.

> On March 7, 2018, 4:13 a.m., Greg Mann wrote: > > src/master/master.cpp > > Line 7722 (original), 7680-7681 (patched) > > > > > > Perhaps we also want to rescind offers when > >

Re: Review Request 65591: Explicitly tracked resource providers in master.

> On March 7, 2018, 3:13 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7324 (patched) > > > > > > Is there any case where `message.has_resource_version_uuid() && > > slave->resourceVersion.isNone()`

Re: Review Request 65591: Explicitly tracked resource providers in master.

> On March 7, 2018, 4:13 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7324 (patched) > > > > > > Is there any case where `message.has_resource_version_uuid() && > > slave->resourceVersion.isNone()`

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/ --- (Updated March 7, 2018, 12:36 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review198741 --- Thanks Benjamin - this is a nice improvement!

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/ --- (Updated March 5, 2018, 11:21 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/ --- (Updated Feb. 23, 2018, 4:22 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 65591: Explicitly tracked resource providers in master.

> On Feb. 16, 2018, 2:13 a.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 7307 (original), 7351 (patched) > > > > > > Do we plan to support resource providers with info (so not the > > agent-default

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/ --- (Updated Feb. 16, 2018, 3:12 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review197652 --- src/master/master.hpp Lines 279-290 (patched)

Re: Review Request 65591: Explicitly tracked resource providers in master.

> On Feb. 13, 2018, 5:30 p.m., Jan Schlicht wrote: > > src/master/master.cpp > > Lines 7334-7336 (patched) > > > > > > You compare operations here for resource providers. This isn't done in > > the code above for

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/ --- (Updated Feb. 15, 2018, 3:54 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review197410 --- src/master/master.cpp Line 7295 (original), 7329 (patched)

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review197222 --- Patch looks great! Reviews applied: [65587, 65588, 65589, 65590,

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review197175 --- PASS: Mesos patch 65591 was successfully built and tested.

Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8382