Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- (Updated April 24, 2018, 1:06 a.m.) Review request for mesos, Benjamin

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

> On April 20, 2018, 12:57 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 3276 (patched) > > > > > > Should we capture this? > > > > ProfileInfo& profile_ =

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

> On April 20, 2018, 12:57 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 3276 (patched) > > > > > > Should we capture this? > > > > ProfileInfo& profile_ =

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

> On April 20, 2018, 12:57 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 1003 (patched) > > > > > > Even thought an `auto` might make sense in such a place _in general_, >

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

> On April 20, 2018, 12:57 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Line 1010 (original), 1011 (patched) > > > > > > Nit: _pending operations_ should be specific enough as

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review201627 --- src/resource_provider/storage/provider.cpp Lines 1003 (patched)

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review201143 --- Ship it! Ship It! - Jie Yu On April 12, 2018, 3:35 a.m.,

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- (Updated April 12, 2018, 3:35 a.m.) Review request for mesos, Benjamin

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- (Updated March 20, 2018, 3:13 a.m.) Review request for mesos, Benjamin

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- (Updated March 9, 2018, 1:38 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

> On Feb. 19, 2018, 3:39 p.m., Benjamin Bannier wrote: > > src/resource_provider/state.proto > > Lines 19 (patched) > > > > > > This file is not present for e.g., cmake builds or more generally when > > not building

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- (Updated March 9, 2018, 1:29 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

> On Feb. 24, 2018, 12:11 a.m., Jie Yu wrote: > > src/resource_provider/storage/provider.cpp > > Line 1304 (original), 1329 (patched) > > > > > > This flag is a bit confusing. When we will set this flag to `true`?

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- (Updated March 8, 2018, 5:04 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review197572 --- src/resource_provider/storage/provider.cpp Line 1304 (original),

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review197757 --- src/resource_provider/state.proto Lines 19 (patched)

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- (Updated Feb. 13, 2018, 10:18 p.m.) Review request for mesos, James DeFelice,

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- (Updated Feb. 12, 2018, 7:07 p.m.) Review request for mesos, James DeFelice,

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

> On Feb. 10, 2018, 2:22 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/storage/uri_disk_profile.cpp > > Line 248 (original), 242 (patched) > > > > > > This should be removed to support missing profiles from

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review197218 --- src/resource_provider/storage/uri_disk_profile.cpp Line 248

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review197213 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. Bugs: