Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated Feb. 27, 2018, 7:05 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review198342 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated March 2, 2018, 7:41 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review198552 --- PASS: Mesos patch 65812 was successfully built and tested. Review

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review198579 --- Patch looks great! Reviews applied: [65811, 65812] Passed comman

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated March 5, 2018, 7:29 a.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review199365 --- 3rdparty/stout/include/stout/os/posix/realpath.hpp Lines 48 (patc

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

> On March 16, 2018, 11:20 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/realpath.hpp > > Lines 48 (patched) > > > > > > Please add unit test for this. Will do in a separate patch. - Jason ---

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated May 8, 2018, 6:43 p.m.) Review request for mesos, Anish Gupta, Eric Ch

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated May 17, 2018, 1:07 a.m.) Review request for mesos, Anish Gupta, Eric C

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review203454 --- It's very hard to reason about the correctness of this patch witho

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review203430 --- 3rdparty/stout/include/stout/os/posix/realpath.hpp Lines 51 (patc

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review203455 --- 3rdparty/stout/include/stout/os/posix/realpath.hpp Lines 68-81 (p

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

> On May 18, 2018, 10:08 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/realpath.hpp > > Lines 51 (patched) > > > > > > Any reason we need this parameter here? Can we just remove this > > parameter, an

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

> On May 18, 2018, 10:12 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/realpath.hpp > > Lines 68-81 (patched) > > > > > > IN fact, I would consider making `unprocessed` a `vector` > > (which is a resu

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated Sept. 21, 2018, 10:45 p.m.) Review request for mesos, Eric Chung, Gilb

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated Nov. 7, 2018, 9:23 p.m.) Review request for mesos, Eric Chung, Gilbert

Review Request 65812: Added an overloaded version of `os::realpath` to stout for evaluating real path within a scoped root directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James P

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout for evaluating real path within a scoped root directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review198317 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout for evaluating real path within a scoped root directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated Feb. 27, 2018, 7:04 p.m.) Review request for mesos, Anish Gupta, Eric