Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

2018-03-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/#review199367 --- Ship it! Ship It! - Jie Yu On March 15, 2018, 10:31 p.m.,

Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

2018-03-16 Thread Jie Yu
> On March 16, 2018, 6:47 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > > Lines 404 (patched) > > > > > > Let's not have this CHECK here. It's possible that cleanup is

Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

2018-03-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/#review199336 --- src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp

Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

2018-03-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/#review199308 --- Patch looks great! Reviews applied: [66104] Passed command:

Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

2018-03-15 Thread Zhitao Li
> On March 15, 2018, 4:33 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > > Lines 404 (patched) > > > > > > Instead of the check failure. We probably should return a

Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

2018-03-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/#review199301 --- PASS: Mesos patch 66104 was successfully built and tested.

Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

2018-03-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/#review199300 --- src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp

Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

2018-03-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/#review199298 --- Ship it! Ship It! - Gilbert Song On March 15, 2018, 3:31

Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

2018-03-15 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/ --- Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, and Zhitao Li.