Re: Review Request 66158: Libprocess: Made tests `GRPCClientTest.*` cross-platform.

2018-03-21 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66158/ --- (Updated March 21, 2018, 8:25 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 66158: Libprocess: Made tests `GRPCClientTest.*` cross-platform.

2018-03-21 Thread Benjamin Bannier
> On March 20, 2018, 4:59 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Lines 67 (patched) > > > > > > nit: Let's make this constructor `explicit`. I think it would also make > >

Re: Review Request 66158: Libprocess: Made tests `GRPCClientTest.*` cross-platform.

2018-03-20 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66158/ --- (Updated March 20, 2018, 10:46 p.m.) Review request for mesos, Andrew Schwartzm

Re: Review Request 66158: libprocess: Made tests `GRPCClientTest.*` cross-platform.

2018-03-20 Thread Chun-Hung Hsiao
> On March 20, 2018, 3:59 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Lines 67 (patched) > > > > > > nit: Let's make this constructor `explicit`. I think it would also make > >

Re: Review Request 66158: libprocess: Made tests `GRPCClientTest.*` cross-platform.

2018-03-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66158/#review199556 --- Fix it, then Ship it! 3rdparty/libprocess/include/process/grpc

Review Request 66158: libprocess: Made tests `GRPCClientTest.*` cross-platform.

2018-03-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66158/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8697 htt