Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-04-25 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review201956 --- Patch looks great! Reviews applied: [66001, 66173] Passed comman

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-04-25 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review201940 --- Ship it! Looks good. There's a coupld of small nits that I'll f

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-04-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review201647 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-04-20 Thread Harold Dost
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/ --- (Updated April 20, 2018, 6:49 p.m.) Review request for mesos and James Peach.

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-04-11 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review200931 --- I'm getting a test failure on `ROOT_XFS_QuotaTest.RecoverOldContai

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-04-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review200474 --- PASS: Mesos patch 66173 was successfully built and tested. Review

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-04-04 Thread Harold Dost
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/ --- (Updated April 4, 2018, 5:41 p.m.) Review request for mesos and James Peach.

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-03-27 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review200057 --- Running the test, I get this failure: ``` ../../src/tests/containe

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-03-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review199819 --- Patch looks great! Reviews applied: [66001, 66173] Passed comman

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-03-22 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review199794 --- In one of the basic quota tests (maybe ROOT_XFS_QuotaTest.QuotaGet

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review199768 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-03-22 Thread Harold Dost
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/ --- (Updated March 22, 2018, 2:11 p.m.) Review request for mesos and James Peach.

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-03-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review199554 --- PASS: Mesos patch 66173 was successfully built and tested. Review

Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-03-20 Thread Harold Dost
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/ --- Review request for mesos and James Peach. Bugs: MESOS-6575 https://issues.a