Re: Review Request 66481: Converted `pid` in command executor to `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/#review200758 --- Ship it! Thanks Zhitao! - Andrew Schwartzmeyer On April 9,

Re: Review Request 66481: Converted `pid` in command executor to `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/ --- (Updated April 9, 2018, 10:20 a.m.) Review request for mesos, Andrew

Re: Review Request 66481: Converted `pid` in command executor to `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/#review200719 --- Fix it, then Ship it! src/launcher/executor.cpp Line 983

Re: Review Request 66481: Converted `pid` in command executor to `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/#review200713 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66481: Converted `pid` in command executor to `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/ --- (Updated April 7, 2018, 5:50 p.m.) Review request for mesos, Andrew

Re: Review Request 66481: Converted `pid` in command executor to `Option`.

> On April 5, 2018, 5:01 p.m., James Peach wrote: > > I think we should just change all the usages of `pid` rather than renaming > > it to `pid_`. Fixed. - Zhitao --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 66481: Converted `pid` in command executor to `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/#review200627 --- Patch looks great! Reviews applied: [66481] Passed command:

Re: Review Request 66481: Converted `pid` in command executor to `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/#review200610 --- PASS: Mesos patch 66481 was successfully built and tested.

Re: Review Request 66481: Converted `pid` in command executor to `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/#review200605 --- I think we should just change all the usages of `pid` rather than

Review Request 66481: Converted `pid` in command executor to `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/ --- Review request for mesos, Andrew Schwartzmeyer and James Peach. Repository: