Re: Review Request 66823: Added per framework metrics for framework events.

2018-07-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/#review205836 --- Bad patch! Reviews applied: [66823] Failed command: python suppo

Re: Review Request 66823: Added per framework metrics for framework events.

2018-07-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/#review205814 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 66823: Added per framework metrics for framework events.

2018-07-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/ --- (Updated July 6, 2018, 6:02 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66823: Added per framework metrics for framework events.

2018-06-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/#review205576 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 66823: Added per framework metrics for framework events.

2018-06-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/#review205574 --- Bad patch! Reviews applied: [66823, 67776, 66820, 66819, 66882]

Re: Review Request 66823: Added per framework metrics for framework events.

2018-06-28 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/ --- (Updated June 28, 2018, 10:41 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66823: Added per framework metrics for framework events.

2018-05-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/ --- (Updated May 15, 2018, 5:41 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66823: Added per framework metrics for framework events.

2018-05-15 Thread Gilbert Song
> On May 15, 2018, 2:58 p.m., Greg Mann wrote: > > src/master/master.hpp > > Lines 2381 (patched) > > > > > > I'm curious what the performance impact of this will be during a period > > of high event throughput. Do

Re: Review Request 66823: Added per framework metrics for framework events.

2018-05-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/#review203166 --- src/master/master.hpp Lines 2381 (patched)

Re: Review Request 66823: Added per framework metrics for framework events.

2018-05-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/ --- (Updated May 11, 2018, 1:44 a.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66823: Added per framework metrics for framework events.

2018-05-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/ --- (Updated May 11, 2018, 12:40 a.m.) Review request for mesos, Benjamin Mahler, G