Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-24 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review203775 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-24 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/ --- (Updated May 24, 2018, 2:45 p.m.) Review request for mesos, Andrew Schwartzmeye

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-24 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review203732 --- Patch looks great! Reviews applied: [67247, 67099, 67059] Passed

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-23 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review203684 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 22, 2018, 8:

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review203594 --- PASS: Mesos patch 67059 was successfully built and tested. Review

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-22 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/ --- (Updated May 22, 2018, 3:55 p.m.) Review request for mesos, Andrew Schwartzmeye

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-15 Thread Andrew Schwartzmeyer
> On May 10, 2018, 1:34 p.m., Andrew Schwartzmeyer wrote: > > support/build-virtualenv > > Lines 49-51 (original), 49-51 (patched) > > > > > > I didn't know where else to comment to open this issue: > > > > W

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-15 Thread Andrew Schwartzmeyer
> On May 10, 2018, 1:34 p.m., Andrew Schwartzmeyer wrote: > > support/python3/apply-reviews.py > > Lines 2-17 (patched) > > > > > > It's unfortunate that due to a staged replacement, we can't review the > > diffs of t

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-11 Thread Armand Grillet
> On mai 10, 2018, 8:34 après-midi, Andrew Schwartzmeyer wrote: > > support/build-virtualenv > > Lines 49-51 (original), 49-51 (patched) > > > > > > I didn't know where else to comment to open this issue: > > > >

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-11 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/ --- (Updated mai 11, 2018, 9:57 après-midi) Review request for mesos, Andrew Schwar

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review202886 --- Patch looks great! Reviews applied: [67055, 67059] Passed comman

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-10 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review202864 --- support/build-virtualenv Lines 49-51 (original), 49-51 (patched)

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-10 Thread Andrew Schwartzmeyer
> On May 10, 2018, 12:36 p.m., Benjamin Bannier wrote: > > Thanks for the work of porting these over to python3 Armand! > > > > Two more high-level comments: > > > > * Why are we not using code compatible with both python2 and 3 instead of > > effectively forking the code? Maintaining two supp

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review202861 --- Thanks for the work of porting these over to python3 Armand! Two

Re: Review Request 67059: Ported all support scripts to Python 3.

2018-05-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review202854 --- PASS: Mesos patch 67059 was successfully built and tested. Review

Review Request 67059: Ported all support scripts to Python 3.

2018-05-10 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, an