Re: Review Request 67632: Always define PICOJSON_USE_INT64.

2018-07-02 Thread Benjamin Bannier
> On July 2, 2018, 11:14 a.m., Alexander Rojas wrote: > > 3rdparty/stout/include/stout/json.hpp > > Lines 25 (patched) > > > > > > This breaks compilation if someone already has define > > `PICOJSON_USE_INT64`. I

Re: Review Request 67632: Always define PICOJSON_USE_INT64.

2018-07-02 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67632/#review205630 --- 3rdparty/stout/include/stout/json.hpp Lines 25 (patched)

Re: Review Request 67632: Always define PICOJSON_USE_INT64.

2018-06-26 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67632/ --- (Updated June 26, 2018, 11:48 a.m.) Review request for mesos. Changes

Re: Review Request 67632: Always define PICOJSON_USE_INT64.

2018-06-25 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67632/#review205303 --- Fix it, then Ship it! 3rdparty/stout/include/stout/json.hpp

Re: Review Request 67632: Always define PICOJSON_USE_INT64.

2018-06-19 Thread Andrew Schwartzmeyer
> On June 18, 2018, 1:23 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/Makefile.am > > Lines 96-99 (original), 96-97 (patched) > > > > > > We should probably remove this from CMake too, yeah? > > > >