Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

2018-08-10 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/ --- (Updated Aug. 10, 2018, 10:36 a.m.) Review request for mesos, Gilbert Song, Jas

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

2018-08-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/#review207052 --- Fix it, then Ship it! Please modify the agent.md src/slave/fl

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

2018-08-06 Thread Benjamin Mahler
> On Aug. 1, 2018, 8:40 p.m., James Peach wrote: > > I don't have a good sense of whether this is going to fix the underlying > > problem, but making it a config option is definitely a benefit and the code > > looks fine. I'm also puzzled about how making something configurable will fix this p

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

2018-08-01 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/#review206755 --- Fix it, then Ship it! I don't have a good sense of whether this

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

2018-07-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/#review206608 --- PASS: Mesos patch 68088 was successfully built and tested. Review

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

2018-07-30 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/#review206604 --- Ship it! Ship It! - Jason Lai On July 30, 2018, 5:50 p.m., Z

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

2018-07-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/ --- (Updated July 30, 2018, 10:50 a.m.) Review request for mesos, Gilbert Song and