Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- (Updated Aug. 16, 2018, 1:54 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- (Updated Aug. 15, 2018, 3:49 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/#review207355 --- Ship it! Ship it after fixing the issues opened by BenM. -

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

> On Aug. 15, 2018, 2:29 p.m., Benjamin Mahler wrote: > > src/slave/slave.cpp > > Lines 1401-1408 (original), 1421-1428 (patched) > > > > > > It seems a little easier to understand the overall approach if you show

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/#review207356 --- Fix it, then Ship it! src/slave/constants.hpp Lines 68-69

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

> On Aug. 14, 2018, 3:30 p.m., Benjamin Mahler wrote: > > src/slave/slave.cpp > > Lines 1287-1290 (original), 1286-1289 (patched) > > > > > > Shouldn't we specialize this between authentication and registration?

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- (Updated Aug. 15, 2018, 11:47 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- (Updated Aug. 14, 2018, 5:47 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/#review207255 --- Per offline conversation, seems like we could simplify this by

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- (Updated Aug. 13, 2018, 10:33 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

> On Aug. 13, 2018, 4:06 p.m., Benjamin Mahler wrote: > > Just a quick review since you're updating the logic. > > > > How about: > > > > ``` > > Fixed a backoff overflow bug in agent authentication retry logic. > > ``` > > > > A little more in the commit description to clarify the old vs new