Re: Review Request 68366: Added agent protected port range option in network isolator.

> On Aug. 22, 2018, 7:27 p.m., James Peach wrote: > > Can you please update the commit comment to better describe the specific > > changes? > > > > Maybe something along these lines: > > > > ``` > > Added a custom port range option to the `network/ports` isolator. > > > > Added the

Re: Review Request 68366: Added agent protected port range option in network isolator.

> On Aug. 22, 2018, 11:50 p.m., James Peach wrote: > > I think this change broke the > > `NetworkPortsIsolatorTest.ROOT_NC_NoPortsResource` test, just regressing > > against master. Fixed it; There was an empty ports condition removed in one of iteration but didn't add back in the later

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207781 --- I think this change broke the

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207762 --- Can you please update the commit comment to better describe the

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207763 --- PASS: Mesos patch 68366 was successfully built and tested.

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 22, 2018, 5:35 p.m.) Review request for mesos and James Peach.

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207644 --- PASS: Mesos patch 68366 was successfully built and tested.

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 20, 2018, 9:53 p.m.) Review request for mesos and James Peach.

Re: Review Request 68366: Added agent protected port range option in network isolator.

> On Aug. 17, 2018, 10:02 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 343 (patched) > > > > > > `flags.container_ports_protected_range` is already an interval

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207581 --- Patch looks great! Reviews applied: [68366] Passed command:

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207557 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Line

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207541 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 17, 2018, 6:27 p.m.) Review request for mesos and James Peach.

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207524 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 17, 2018, 5:21 p.m.) Review request for mesos and James Peach.

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207478 --- Patch looks great! Reviews applied: [68366] Passed command:

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207461 --- PASS: Mesos patch 68366 was successfully built and tested.

Re: Review Request 68366: Added agent protected port range option in network isolator.

> On Aug. 16, 2018, 5:22 p.m., James Peach wrote: > > As per our offline discussion, I think that we can generalize this to make > > it consistent with the existing options. If we have the concept of a > > protected port range, then the existing features map to "protect all ports" > > and

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 16, 2018, 9:28 p.m.) Review request for mesos and James Peach.