Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/ --- Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Repository: mesos

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/ --- (Updated Oct. 24, 2018, 4:12 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review21 --- Fix it, then Ship it! src/tests/fetcher_tests.cpp Lines 105-10

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 4:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely consisten

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 11:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely consiste

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 4:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely consisten

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 11:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely consiste

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210005 --- PASS: Mesos patch 69146 was successfully built and tested. Review

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 4:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely consisten

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 11:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely consiste

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210021 --- src/tests/fetcher_tests.cpp Line 120 (original), 132 (patched)

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210022 --- src/tests/fetcher_tests.cpp Lines 98-109 (patched)

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/ --- (Updated Oct. 25, 2018, 12:34 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 4:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely consisten

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 11:54 p.m., Benjamin Bannier wrote: > > src/tests/fetcher_tests.cpp > > Lines 98-109 (patched) > > > > > > We can avoid duplication here by making `FetcherTest` a `MesosTest` > > (that one would a

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210055 --- PASS: Mesos patch 69146 was successfully built and tested. Review

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210143 --- Ship it! Ship It! - Joseph Wu On Oct. 25, 2018, 12:34 p.m.,