Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

2018-11-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/ --- (Updated Nov. 22, 2018, 10:37 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

2018-11-20 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/ --- (Updated Nov. 21, 2018, 3:43 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

2018-11-20 Thread Chun-Hung Hsiao
> On Nov. 20, 2018, 1:16 p.m., Benjamin Bannier wrote: > > src/examples/test_csi_plugin.cpp > > Lines 367-370 (patched) > > > > > > Can we move this block and the one below outside of the conditional or > > do we

Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

2018-11-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/#review210711 --- Ship it! src/examples/test_csi_plugin.cpp Lines 367-370

Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

2018-11-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/ --- (Updated Nov. 19, 2018, 11:35 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

2018-11-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/#review210610 --- This patch seems to contain at the same time 1) addition of the

Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

2018-11-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-9275