Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

2018-12-10 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69540/ --- Review request for mesos, Jie Yu and James Peach. Bugs: MESOS-9462 https://

Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

2018-12-10 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69540/#review211146 --- Fix it, then Ship it! src/tests/containerizer/linux_filesystem

Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

2018-12-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69540/#review211151 --- Ship it! Ship It! - Jie Yu On Dec. 10, 2018, 4:41 p.m., Andr

Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

2018-12-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69540/#review211156 --- PASS: Mesos patch 69540 was successfully built and tested. Review

Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

2018-12-10 Thread Andrei Budnik
> On Dec. 10, 2018, 5:06 p.m., James Peach wrote: > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > > Lines 137 (patched) > > > > > > As a separate commit, can we factor out the flags set up from all

Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

2018-12-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69540/#review211175 --- Ship it! Ship It! - Gilbert Song On Dec. 10, 2018, 8:41 a.m.