Re: Review Request 69811: Preliminary SLRP refactoring for RPC retry.

2019-01-25 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69811/ --- (Updated Jan. 26, 2019, 12:17 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69811: Preliminary SLRP refactoring for RPC retry.

2019-01-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69811/#review212320 --- Ship it! LGTM, still need to go through the rest of the chain.

Re: Review Request 69811: Preliminary SLRP refactoring for RPC retry.

2019-01-23 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69811/ --- (Updated Jan. 24, 2019, 6:05 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69811: Preliminary SLRP refactoring for RPC retry.

2019-01-23 Thread Chun-Hung Hsiao
> On Jan. 23, 2019, 2:34 p.m., Benjamin Bannier wrote: > > This looks in general like a great simplification, but it does at least > > superficually look like this is more that a (non-functional) refactoring; > > we now do pull some internal state before making some calls, but the actual > > c

Re: Review Request 69811: Preliminary SLRP refactoring for RPC retry.

2019-01-23 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69811/#review212241 --- src/resource_provider/storage/provider.cpp Lines 395 (patched)

Re: Review Request 69811: Preliminary SLRP refactoring for RPC retry.

2019-01-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69811/#review212233 --- This looks in general like a great simplification, but it does at

Review Request 69811: Preliminary SLRP refactoring for RPC retry.

2019-01-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69811/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES