Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

2019-02-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9544 https://iss

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

2019-02-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/#review212730 --- PASS: Mesos patch 69955 was successfully built and tested. Review

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

2019-03-02 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/#review213349 --- Bad review! Reviews applied: [69955, 69954, 69403, 69905, 69904,

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

2019-03-04 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/ --- (Updated March 4, 2019, 7:23 p.m.) Review request for mesos and Benjamin Bannie

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

2019-03-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/#review213689 --- PASS: Mesos patch 69955 was successfully built and tested. Review

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

2019-04-12 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/ --- (Updated April 12, 2019, 10:02 p.m.) Review request for mesos and Benjamin Bann

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

2019-04-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/#review214646 --- Patch looks great! Reviews applied: [70468, 70431, 69954, 69955]

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

2019-04-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/#review214649 --- PASS: Mesos patch 69955 was successfully built and tested. Review

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

2019-04-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/#review214690 --- Fix it, then Ship it! src/tests/storage_local_resource_provide

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

2019-04-16 Thread Chun-Hung Hsiao
> On April 16, 2019, 1:18 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3328 (patched) > > > > > > If we need to await offers, lets also check their contents. It see

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

2019-05-02 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/ --- (Updated May 2, 2019, 10:46 p.m.) Review request for mesos and Benjamin Bannier