Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-04-01 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/ --- (Updated April 2, 2019, 6:13 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-04-01 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/#review214259 --- FAIL: Failed to apply the dependent review: 70225. Failed command

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-03-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/#review214227 --- FAIL: Failed to apply the dependent review: 70225. Failed command

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-03-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/#review214221 --- Bad review! Reviews applied: [70321, 70303, 70302, 70225, 70223,

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-03-28 Thread Chun-Hung Hsiao
> On March 28, 2019, 12:37 p.m., Benjamin Bannier wrote: > > src/tests/csi_client_tests.cpp > > Line 86 (original), 83 (patched) > > > > > > Not started here, but I believe we strive to distinguish members by > > app

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-03-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/#review214173 --- Fix it, then Ship it! While I think such cleanups are totally w

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-03-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/#review214167 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-03-28 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/ --- (Updated March 28, 2019, 8:02 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-03-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/#review214158 --- Bad review! Reviews applied: [70321, 70303, 70302, 70225, 70223,

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-03-27 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/#review214112 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-03-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/#review214092 --- Bad review! Reviews applied: [70321, 70303, 70302, 70248, 70247,

Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-03-27 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/#review214085 --- FAIL: Failed to apply the dependent review: 70302. Failed command

Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.

2019-03-26 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES