Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

> On June 10, 2019, 3:08 a.m., Benjamin Mahler wrote: > > Looks good, thanks! > > > > I will make some adjustments prior to committing, the biggest is to remove > > the need for the nullptr assingment and loop check, by using finalize() > > instead of shutdown(). Also will add a receiveLoop

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/#review215771 --- Fix it, then Ship it! Looks good, thanks! I will make some

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- (Updated June 7, 2019, 4:21 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- (Updated June 3, 2019, 8:28 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- (Updated June 3, 2019, 8:22 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

> On May 29, 2019, 6:02 p.m., Benjamin Mahler wrote: > > src/tests/master/mock_master_api_subscriber.cpp > > Lines 131-134 (patched) > > > > > > If possible, we prefer to use the "managed=true" approach to avoid >

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- (Updated June 3, 2019, 7:55 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/#review215617 --- Fix it, then Ship it! This looks pretty sweet, thanks for

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

> On May 29, 2019, 6:02 p.m., Benjamin Mahler wrote: > > src/tests/master/mock_master_api_subscriber.cpp > > Lines 131-134 (patched) > > > > > > If possible, we prefer to use the "managed=true" approach to avoid >

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- (Updated May 29, 2019, 6:26 p.m.) Review request for mesos and Benjamin

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/#review215579 --- Overall this is looking pretty good, thanks Andrei!

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

> On May 24, 2019, 2:54 p.m., Benjamin Mahler wrote: > > src/tests/mock_master_api_subscriber.hpp > > Lines 60-63 (patched) > > > > > > Per my comment above, since we want to use this class to improve the > >

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- (Updated May 28, 2019, 5:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

> On May 24, 2019, 2:54 p.m., Benjamin Mahler wrote: > > Thanks for adding this: > > > > (1) If we're going to introduce this, let's include a patch after it that > > updates all the `SUBSCRIBE` related tests in `src/tests/api_tests.cpp` to > > use this. > > (2) Can you also include some

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/#review215497 --- Thanks for adding this: (1) If we're going to introduce this,

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- (Updated May 21, 2019, 1:54 p.m.) Review request for mesos and Benjamin

Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description