Re: Review Request 70748: Disallow verification of empty TLS server certificates.

> On June 14, 2019, 12:44 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Line 738 (original), 745 (patched) > > > > > > This means that when a certificate gets provided, we always validate >

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/ --- (Updated June 14, 2019, 11:40 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/#review215878 --- 3rdparty/libprocess/src/openssl.cpp Line 738 (original), 745 (pat

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

> On May 31, 2019, 3:05 p.m., Alexander Rukletsov wrote: > > The code looks good to me. Thanks! > > > > As part of this change, either here or in separate reviews, let us: > > - call out the modification in the changelog; > > - mention taken approach in MESOS-9791 and explain why (based on the

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

> On May 31, 2019, 3:05 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp > > Lines 287-290 (patched) > > > > > > Can we also test that a client must *not* present a cert? I believe the

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/ --- (Updated June 6, 2019, 11:12 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/#review215616 --- The code looks good to me. Thanks! As part of this change, either

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/ --- (Updated May 31, 2019, 2:34 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/ --- (Updated May 31, 2019, 2:06 p.m.) Review request for mesos, Alexander Rukletsov

Review Request 70748: Disallow verification of empty TLS server certificates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/ --- Review request for mesos, Alexander Rukletsov, Jan-Philip Gehrcke, and Till Toen